kjanat/livedash-node
1
0
Fork 0
mirror of https://github.com/kjanat/livedash-node.git synced 2026-01-16 08:32:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code for improved readability and consistency

Browse Source 
- Updated formatting in SessionDetails component for better readability.
- Enhanced documentation in scheduler-fixes.md to clarify issues and solutions.
- Improved error handling and logging in csvFetcher.js and processingScheduler.js.
- Standardized code formatting across various scripts and components for consistency.
- Added validation checks for CSV URLs and transcript content to prevent processing errors.
- Enhanced logging messages for better tracking of processing status and errors.
This commit is contained in:
Max Kowalski
2025-06-25 17:46:23 +02:00
parent a9e4145001
commit 9e095e1a43
16 changed files with 455 additions and 259 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
scripts/manual-triggers.js
View File

@ -48,7 +48,7 @@ async function triggerProcessingScheduler() {
});
console.log(`Found ${sessionsToProcess.length} sessions to process:`);
sessionsToProcess.forEach(session => {
sessionsToProcess.forEach((session) => {
console.log(`- Session ${session.id}: processed=${session.processed}`);
});
@ -58,7 +58,9 @@ async function triggerProcessingScheduler() {
}
// Import and run the processing function
const { processUnprocessedSessions } = await import("../lib/processingScheduler.js");
const { processUnprocessedSessions } = await import(
"../lib/processingScheduler.js"
);
await processUnprocessedSessions();
console.log("✅ Processing scheduler completed");
@ -74,7 +76,9 @@ async function triggerTranscriptParsing() {
console.log("=== Manual Transcript Parsing Trigger ===");
try {
const result = await processAllUnparsedTranscripts();
console.log(`✅ Transcript parsing completed: ${result.processed} processed, ${result.errors} errors`);
console.log(
`✅ Transcript parsing completed: ${result.processed} processed, ${result.errors} errors`
);
} catch (error) {
console.error("❌ Transcript parsing failed:", error);
}
@ -89,25 +93,22 @@ async function showProcessingStatus() {
try {
const totalSessions = await prisma.session.count();
const processedSessions = await prisma.session.count({
where: { processed: true }
where: { processed: true },
});
const unprocessedSessions = await prisma.session.count({
where: { processed: { not: true } }
where: { processed: { not: true } },
});
const withMessages = await prisma.session.count({
where: {
messages: {
some: {}
}
}
some: {},
},
},
});
const readyForProcessing = await prisma.session.count({
where: {
AND: [
{ messages: { some: {} } },
{ processed: { not: true } }
]
}
AND: [{ messages: { some: {} } }, { processed: { not: true } }],
},
});
console.log(`📊 Total sessions: ${totalSessions}`);
@ -121,24 +122,22 @@ async function showProcessingStatus() {
console.log("\n📋 Sample unprocessed sessions:");
const samples = await prisma.session.findMany({
where: {
AND: [
{ messages: { some: {} } },
{ processed: { not: true } }
]
AND: [{ messages: { some: {} } }, { processed: { not: true } }],
},
select: {
id: true,
processed: true,
startTime: true,
},
take: 3
take: 3,
});
samples.forEach(session => {
console.log(`- ${session.id} (${session.startTime.toISOString()}) - processed: ${session.processed}`);
samples.forEach((session) => {
console.log(
`- ${session.id} (${session.startTime.toISOString()}) - processed: ${session.processed}`
);
});
}
} catch (error) {
console.error("❌ Failed to get processing status:", error);
}
@ -148,24 +147,24 @@ async function showProcessingStatus() {
const command = process.argv[2];
switch (command) {
case 'refresh':
case "refresh":
await triggerSessionRefresh();
break;
case 'process':
case "process":
await triggerProcessingScheduler();
break;
case 'parse':
case "parse":
await triggerTranscriptParsing();
break;
case 'status':
case "status":
await showProcessingStatus();
break;
case 'both':
case "both":
await triggerSessionRefresh();
console.log("\n" + "=".repeat(50) + "\n");
await triggerProcessingScheduler();
break;
case 'all':
case "all":
await triggerSessionRefresh();
console.log("\n" + "=".repeat(50) + "\n");
await triggerTranscriptParsing();
@ -175,9 +174,13 @@ switch (command) {
default:
console.log("Usage: node scripts/manual-triggers.js [command]");
console.log("Commands:");
console.log(" refresh - Trigger session refresh (fetch new sessions from CSV)");
console.log(
" refresh - Trigger session refresh (fetch new sessions from CSV)"
);
console.log(" parse - Parse transcripts into structured messages");
console.log(" process - Trigger processing scheduler (process unprocessed sessions)");
console.log(
" process - Trigger processing scheduler (process unprocessed sessions)"
);
console.log(" status - Show current processing status");
console.log(" both - Run both refresh and processing");
console.log(" all - Run refresh, parse, and processing in sequence");

26
scripts/process_sessions.mjs
View File

@ -125,7 +125,9 @@ function validateOpenAIResponse(data) {
// Validate field types
if (typeof data.language !== "string" || !/^[a-z]{2}$/.test(data.language)) {
throw new Error("Invalid language format. Expected ISO 639-1 code (e.g., 'en')");
throw new Error(
"Invalid language format. Expected ISO 639-1 code (e.g., 'en')"
);
}
if (typeof data.messages_sent !== "number" || data.messages_sent < 0) {
@ -133,7 +135,9 @@ function validateOpenAIResponse(data) {
}
if (!["positive", "neutral", "negative"].includes(data.sentiment)) {
throw new Error("Invalid sentiment. Expected 'positive', 'neutral', or 'negative'");
throw new Error(
"Invalid sentiment. Expected 'positive', 'neutral', or 'negative'"
);
}
if (typeof data.escalated !== "boolean") {
@ -161,15 +165,23 @@ function validateOpenAIResponse(data) {
];
if (!validCategories.includes(data.category)) {
throw new Error(`Invalid category. Expected one of: ${validCategories.join(", ")}`);
throw new Error(
`Invalid category. Expected one of: ${validCategories.join(", ")}`
);
}
if (!Array.isArray(data.questions)) {
throw new Error("Invalid questions. Expected array of strings");
}
if (typeof data.summary !== "string" || data.summary.length < 10 || data.summary.length > 300) {
throw new Error("Invalid summary. Expected string between 10-300 characters");
if (
typeof data.summary !== "string" ||
data.summary.length < 10 ||
data.summary.length > 300
) {
throw new Error(
"Invalid summary. Expected string between 10-300 characters"
);
}
if (typeof data.session_id !== "string") {
@ -210,7 +222,9 @@ async function processUnprocessedSessions() {
for (const session of sessionsToProcess) {
if (!session.transcriptContent) {
// Should not happen due to query, but good for type safety
console.warn(`Session ${session.id} has no transcript content, skipping.`);
console.warn(
`Session ${session.id} has no transcript content, skipping.`
);
continue;
}

32
scripts/process_sessions.ts
View File

@ -101,7 +101,7 @@ async function processTranscriptWithOpenAI(
throw new Error(`OpenAI API error: ${response.status} - ${errorText}`);
}
const data = await response.json() as any;
const data = (await response.json()) as any;
const processedData = JSON.parse(data.choices[0].message.content);
// Validate the response against our expected schema
@ -118,7 +118,9 @@ async function processTranscriptWithOpenAI(
* Validates the OpenAI response against our expected schema
* @param data The data to validate
*/
function validateOpenAIResponse(data: any): asserts data is OpenAIProcessedData {
function validateOpenAIResponse(
data: any
): asserts data is OpenAIProcessedData {
// Check required fields
const requiredFields = [
"language",
@ -140,7 +142,9 @@ function validateOpenAIResponse(data: any): asserts data is OpenAIProcessedData
// Validate field types
if (typeof data.language !== "string" || !/^[a-z]{2}$/.test(data.language)) {
throw new Error("Invalid language format. Expected ISO 639-1 code (e.g., 'en')");
throw new Error(
"Invalid language format. Expected ISO 639-1 code (e.g., 'en')"
);
}
if (typeof data.messages_sent !== "number" || data.messages_sent < 0) {
@ -148,7 +152,9 @@ function validateOpenAIResponse(data: any): asserts data is OpenAIProcessedData
}
if (!["positive", "neutral", "negative"].includes(data.sentiment)) {
throw new Error("Invalid sentiment. Expected 'positive', 'neutral', or 'negative'");
throw new Error(
"Invalid sentiment. Expected 'positive', 'neutral', or 'negative'"
);
}
if (typeof data.escalated !== "boolean") {
@ -176,15 +182,23 @@ function validateOpenAIResponse(data: any): asserts data is OpenAIProcessedData
];
if (!validCategories.includes(data.category)) {
throw new Error(`Invalid category. Expected one of: ${validCategories.join(", ")}`);
throw new Error(
`Invalid category. Expected one of: ${validCategories.join(", ")}`
);
}
if (!Array.isArray(data.questions)) {
throw new Error("Invalid questions. Expected array of strings");
}
if (typeof data.summary !== "string" || data.summary.length < 10 || data.summary.length > 300) {
throw new Error("Invalid summary. Expected string between 10-300 characters");
if (
typeof data.summary !== "string" ||
data.summary.length < 10 ||
data.summary.length > 300
) {
throw new Error(
"Invalid summary. Expected string between 10-300 characters"
);
}
if (typeof data.session_id !== "string") {
@ -225,7 +239,9 @@ async function processUnprocessedSessions() {
for (const session of sessionsToProcess) {
if (!session.transcriptContent) {
// Should not happen due to query, but good for type safety
console.warn(`Session ${session.id} has no transcript content, skipping.`);
console.warn(
`Session ${session.id} has no transcript content, skipping.`
);
continue;
}