Refactor code for improved readability and consistency

- Updated formatting in SessionDetails component for better readability.
- Enhanced documentation in scheduler-fixes.md to clarify issues and solutions.
- Improved error handling and logging in csvFetcher.js and processingScheduler.js.
- Standardized code formatting across various scripts and components for consistency.
- Added validation checks for CSV URLs and transcript content to prevent processing errors.
- Enhanced logging messages for better tracking of processing status and errors.
This commit is contained in:
Max Kowalski
2025-06-25 17:46:23 +02:00
parent a9e4145001
commit 9e095e1a43
16 changed files with 455 additions and 259 deletions

View File

@ -126,7 +126,9 @@ function validateOpenAIResponse(data) {
// Validate field types
if (typeof data.language !== "string" || !/^[a-z]{2}$/.test(data.language)) {
throw new Error("Invalid language format. Expected ISO 639-1 code (e.g., 'en')");
throw new Error(
"Invalid language format. Expected ISO 639-1 code (e.g., 'en')"
);
}
if (typeof data.messages_sent !== "number" || data.messages_sent < 0) {
@ -134,7 +136,9 @@ function validateOpenAIResponse(data) {
}
if (!["positive", "neutral", "negative"].includes(data.sentiment)) {
throw new Error("Invalid sentiment. Expected 'positive', 'neutral', or 'negative'");
throw new Error(
"Invalid sentiment. Expected 'positive', 'neutral', or 'negative'"
);
}
if (typeof data.escalated !== "boolean") {
@ -162,15 +166,23 @@ function validateOpenAIResponse(data) {
];
if (!validCategories.includes(data.category)) {
throw new Error(`Invalid category. Expected one of: ${validCategories.join(", ")}`);
throw new Error(
`Invalid category. Expected one of: ${validCategories.join(", ")}`
);
}
if (!Array.isArray(data.questions)) {
throw new Error("Invalid questions. Expected array of strings");
}
if (typeof data.summary !== "string" || data.summary.length < 10 || data.summary.length > 300) {
throw new Error("Invalid summary. Expected string between 10-300 characters");
if (
typeof data.summary !== "string" ||
data.summary.length < 10 ||
data.summary.length > 300
) {
throw new Error(
"Invalid summary. Expected string between 10-300 characters"
);
}
if (typeof data.session_id !== "string") {
@ -182,7 +194,9 @@ function validateOpenAIResponse(data) {
* Process unprocessed sessions
*/
export async function processUnprocessedSessions() {
process.stdout.write("[ProcessingScheduler] Starting to process unprocessed sessions...\n");
process.stdout.write(
"[ProcessingScheduler] Starting to process unprocessed sessions...\n"
);
// Find sessions that have messages but haven't been processed
const sessionsToProcess = await prisma.session.findMany({
@ -193,43 +207,58 @@ export async function processUnprocessedSessions() {
},
include: {
messages: {
orderBy: { order: 'asc' }
}
orderBy: { order: "asc" },
},
},
take: 10, // Process in batches to avoid overloading the system
});
// Filter to only sessions that have messages
const sessionsWithMessages = sessionsToProcess.filter(session => session.messages.length > 0);
const sessionsWithMessages = sessionsToProcess.filter(
(session) => session.messages.length > 0
);
if (sessionsWithMessages.length === 0) {
process.stdout.write("[ProcessingScheduler] No sessions found requiring processing.\n");
process.stdout.write(
"[ProcessingScheduler] No sessions found requiring processing.\n"
);
return;
}
process.stdout.write(`[ProcessingScheduler] Found ${sessionsWithMessages.length} sessions to process.\n`);
process.stdout.write(
`[ProcessingScheduler] Found ${sessionsWithMessages.length} sessions to process.\n`
);
let successCount = 0;
let errorCount = 0;
for (const session of sessionsWithMessages) {
if (session.messages.length === 0) {
process.stderr.write(`[ProcessingScheduler] Session ${session.id} has no messages, skipping.\n`);
process.stderr.write(
`[ProcessingScheduler] Session ${session.id} has no messages, skipping.\n`
);
continue;
}
process.stdout.write(`[ProcessingScheduler] Processing messages for session ${session.id}...\n`);
process.stdout.write(
`[ProcessingScheduler] Processing messages for session ${session.id}...\n`
);
try {
// Convert messages back to transcript format for OpenAI processing
const transcript = session.messages.map(msg =>
`[${new Date(msg.timestamp).toLocaleString('en-GB', {
day: '2-digit',
month: '2-digit',
year: 'numeric',
hour: '2-digit',
minute: '2-digit',
second: '2-digit'
}).replace(',', '')}] ${msg.role}: ${msg.content}`
).join('\n');
const transcript = session.messages
.map(
(msg) =>
`[${new Date(msg.timestamp)
.toLocaleString("en-GB", {
day: "2-digit",
month: "2-digit",
year: "numeric",
hour: "2-digit",
minute: "2-digit",
second: "2-digit",
})
.replace(",", "")}] ${msg.role}: ${msg.content}`
)
.join("\n");
const processedData = await processTranscriptWithOpenAI(
session.id,
@ -260,17 +289,25 @@ export async function processUnprocessedSessions() {
},
});
process.stdout.write(`[ProcessingScheduler] Successfully processed session ${session.id}.\n`);
process.stdout.write(
`[ProcessingScheduler] Successfully processed session ${session.id}.\n`
);
successCount++;
} catch (error) {
process.stderr.write(`[ProcessingScheduler] Error processing session ${session.id}: ${error}\n`);
process.stderr.write(
`[ProcessingScheduler] Error processing session ${session.id}: ${error}\n`
);
errorCount++;
}
}
process.stdout.write("[ProcessingScheduler] Session processing complete.\n");
process.stdout.write(`[ProcessingScheduler] Successfully processed: ${successCount} sessions.\n`);
process.stdout.write(`[ProcessingScheduler] Failed to process: ${errorCount} sessions.\n`);
process.stdout.write(
`[ProcessingScheduler] Successfully processed: ${successCount} sessions.\n`
);
process.stdout.write(
`[ProcessingScheduler] Failed to process: ${errorCount} sessions.\n`
);
}
/**
@ -282,9 +319,13 @@ export function startProcessingScheduler() {
try {
await processUnprocessedSessions();
} catch (error) {
process.stderr.write(`[ProcessingScheduler] Error in scheduler: ${error}\n`);
process.stderr.write(
`[ProcessingScheduler] Error in scheduler: ${error}\n`
);
}
});
process.stdout.write("[ProcessingScheduler] Started processing scheduler (runs hourly).\n");
process.stdout.write(
"[ProcessingScheduler] Started processing scheduler (runs hourly).\n"
);
}