ci: bump to Go 1.26 and address PR review feedback

The autofix failure is fixed properly by moving to Go 1.26 instead of the GOTOOLCHAIN workaround. The official golangci-lint v2.12.2 binary is built with go1.26.2 and lints a Go 1.26 target fine (the earlier "not ready" claim was from a locally go-installed binary compiled with Go 1.25), and the Dockerfiles already use golang:1.26-alpine, so this also aligns the module with the images. - go.mod: go 1.25.0 -> 1.26.0, drop the toolchain pin (keeps the lint target at the go directive). - Taskfile: revert modernize to plain modernize@latest; on Go 1.26 the GOTOOLCHAIN dance and its comments are unnecessary. - ci.yml: pass the resolved Go version through an env var (GO_VERSION) instead of interpolating steps.setup-go.outputs.go-version directly into shell scripts (script-injection hygiene); grant the dependency-review job pull-requests: write so it can post its summary. - parser.go: derive defaultBaseURL from riseHost instead of duplicating the host string; drop the redundant per-const comments. - .golangci.yml: remove the redundant go-version comment. - regenerate internal/exporters/output.docx.
ci: set GOTOOLCHAIN=auto inline for the modernize task
2026-08-05 18:04:07 +02:00 · 2026-06-15 17:42:49 +00:00 · 2026-06-15 17:31:39 +00:00 · 2026-06-15 17:29:00 +00:00 · 2026-06-15 17:24:05 +00:00 · 2026-06-15 17:13:09 +00:00
2 changed files with 5 additions and 5 deletions
@@ -381,13 +381,13 @@ jobs:
        uses: actions/checkout@v6

      - name: Login to Docker Hub
-        uses: docker/login-action@v4
+        uses: docker/login-action@v3
        with:
          username: ${{ vars.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

      - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v4
+        uses: docker/login-action@v3
        with:
          registry: ${{ env.REGISTRY }}
          username: ${{ github.actor }}
@@ -62,7 +62,7 @@ jobs:
          done

      - name: Create Release
-        uses: softprops/action-gh-release@v3
+        uses: softprops/action-gh-release@v2
        with:
          files: |
            build/articulate-parser-linux-amd64
@@ -91,13 +91,13 @@ jobs:
        uses: actions/checkout@v6

      - name: Login to Docker Hub
-        uses: docker/login-action@v4
+        uses: docker/login-action@v3
        with:
          username: ${{ vars.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}

      - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v4
+        uses: docker/login-action@v3
        with:
          registry: ${{ env.REGISTRY }}
          username: ${{ github.actor }}
Author	SHA1	Message	Date
kjanat	ea3f74c1b3	ci: bump to Go 1.26 and address PR review feedback The autofix failure is fixed properly by moving to Go 1.26 instead of the GOTOOLCHAIN workaround. The official golangci-lint v2.12.2 binary is built with go1.26.2 and lints a Go 1.26 target fine (the earlier "not ready" claim was from a locally go-installed binary compiled with Go 1.25), and the Dockerfiles already use golang:1.26-alpine, so this also aligns the module with the images. - go.mod: go 1.25.0 -> 1.26.0, drop the toolchain pin (keeps the lint target at the go directive). - Taskfile: revert modernize to plain modernize@latest; on Go 1.26 the GOTOOLCHAIN dance and its comments are unnecessary. - ci.yml: pass the resolved Go version through an env var (GO_VERSION) instead of interpolating steps.setup-go.outputs.go-version directly into shell scripts (script-injection hygiene); grant the dependency-review job pull-requests: write so it can post its summary. - parser.go: derive defaultBaseURL from riseHost instead of duplicating the host string; drop the redundant per-const comments. - .golangci.yml: remove the redundant go-version comment. - regenerate internal/exporters/output.docx.	2026-06-15 17:42:49 +00:00
kjanat	b6f55156c4	ci: set GOTOOLCHAIN=auto inline for the modernize task A task-level env: entry does not override GOTOOLCHAIN when setup-go has already exported GOTOOLCHAIN=local job-wide, so the autofix job still failed. Set GOTOOLCHAIN=auto inline on the modernize command itself, which reliably overrides the inherited value and lets Go fetch the toolchain the modernize analyzer requires.	2026-06-15 17:31:39 +00:00
kjanat	0827024e75	ci: keep modernize@latest, fetch its toolchain via GOTOOLCHAIN=auto Replaces the earlier v0.21.0 pin. The modernize analyzer (gopls v0.22+) requires Go 1.26, which the project doesn't target yet — and bumping the module to 1.26 isn't viable because the current golangci-lint release is built with Go 1.25 and refuses to lint a newer target. Instead, let the modernize task fetch the toolchain it needs on demand via GOTOOLCHAIN=auto (setup-go pins GOTOOLCHAIN=local in CI), so we stay on the latest analyzer without touching the module's Go version. Also bump golang.org/x/image v0.34.0 -> v0.42.0 via `go get -u ./...`.	2026-06-15 17:29:00 +00:00
kjanat	3b0090c692	ci: pin modernize tool to gopls v0.21.x for Go 1.25 compatibility The autofix workflow's `task modernize` step installed the modernize analyzer from gopls@latest, which as of v0.22.0 requires Go 1.26. The project targets Go 1.25 (go.mod) and CI runs with GOTOOLCHAIN=local, so the install failed. Pin to the v0.21.x line, which supports Go >= 1.25.	2026-06-15 17:24:05 +00:00
kjanat	d50a110351	docs: remove emojis from README	2026-06-15 17:13:09 +00:00
kjanat	7933f52003	ci: drop test matrix, run a single Go version from go.mod The test job ran a 1.24.x/1.25.x matrix, but go.mod requires go 1.25.0, so the 1.24 entry just auto-downloaded the 1.25 toolchain and tested the same thing twice. Replace the matrix with a single job that sources its Go version from go.mod via go-version-file, and reference the resolved version through the setup-go step output in summaries, artifact names, and Codecov flags.	2026-06-15 17:12:19 +00:00
kjanat	bf07d6a172	fix(lint): resolve golangci-lint failures and modernize string handling CI's golangci-lint (v2.12.2) job was failing with 14 issues, which blocked the dependent test job. This addresses all of them: - goconst: extract repeated string literals into constants - format aliases ("md", "word", "htm") in the exporter factory - "section" lesson type shared by markdown and HTML exporters - default Articulate Rise base URL and host in the parser - reuse existing itemType* constants in the markdown switch - staticcheck (QF1012): replace buf.WriteString(fmt.Sprintf(...)) with fmt.Fprintf(...) in the markdown exporter Also drop the hardcoded `go: "1.24"` from .golangci.yml so the target Go version is autodetected from go.mod.	2026-06-15 16:59:06 +00:00